Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass span options in RootsSpan #818

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

msosnicki
Copy link
Contributor

Wanted to ask if there is any reason why the Span.Options are not passed from RootsSpan? Currently RootsSpan is only used for IOLocal based implementation, but if typelevel/natchez-http4s#34 is accepted, it will be needed for both IOLocal and Kleisli to propagate options from RootsSpan correctly.

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was just an oversight?

@mpilquist mpilquist merged commit 2a14b09 into typelevel:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants