-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc: allow extracting individual steps (#2065) #2154
base: main
Are you sure you want to change the base?
poc: allow extracting individual steps (#2065) #2154
Conversation
f3787de
to
a70a98c
Compare
@@ -226,6 +248,18 @@ object connection { | |||
} yield ele | |||
} | |||
|
|||
def stream[A: Read]( | |||
prepared: PreparedExecutionStream, | |||
loggingInfo: LoggingInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure these methods are really needed? Especially since the current API does not really allow users to work with (execute) a PreparedExecutionStream directly
I agree with the overall direction you're going with this. I think it will provide most if not all of the customizations users will need 👍 |
a70a98c
to
91effe2
Compare
592f967
to
1423839
Compare
82a5749
to
d91641a
Compare
Methods added to Query class:
Methods added to Update class:
So basically all operations returning Now some questions:
|
Thanks this looks good! Sorry for the late reply. I think Yes we'll need to add these to Query0 and Update0 too |
@jatcwang a promised PoC so we can make some decisions early on :)