Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdoc guards to test-runtime.md. #4097

Open
wants to merge 2 commits into
base: series/3.5.x
Choose a base branch
from

Conversation

kamilkloch
Copy link
Contributor

Fixes #4095.

@TonioGela
Copy link
Member

@kamilkloch I think the error might be due to the fact that munit-cats-effect 2.0.0 is released against Scala 3.3.3, while the Scala 3 build here is against 3.2.2.

@kamilkloch
Copy link
Contributor Author

@kamilkloch I think the error might be due to the fact that munit-cats-effect 2.0.0 is released against Scala 3.3.3, while the Scala 3 build here is against 3.2.2.

Thank you for the valuable hint! Is there any way a develper can see the min required Scala 3 version on an artifact? No hint in maven: https://mvnrepository.com/artifact/org.typelevel/munit-cats-effect_3/2.0.0

@mzuehlke
Copy link
Contributor

mzuehlke commented Jul 3, 2024

Is there any way a develper can see the min required Scala 3 version on an artifact? No hint in maven: mvnrepository.com/artifact/org.typelevel/munit-cats-effect_3/2.0.0

@kamilkloch
Copy link
Contributor Author

@mzuehlke Thank you!
Also, I am pasting here a crazy snippet by @indoorvivants to resolve the dependencies using scala-cli:

$ echo "coursier.cli.Coursier.main(args)" | scala-cli run _.sc --dep io.get-coursier:coursier-cli_2.13:latest.release -- resolve org.typelevel:munit-cats-effect_3:2.0.0
Compiling project (Scala 3.4.2, JVM (17))
Compiled project (Scala 3.4.2, JVM (17))
junit:junit:4.13.2:default
org.hamcrest:hamcrest-core:1.3:default
org.scala-lang:scala-library:2.13.12:default
org.scala-lang:scala3-library_3:3.3.3:default
org.scala-sbt:test-interface:1.0:default
org.scalameta:junit-interface:1.0.0:default
org.scalameta:munit-diff_3:1.0.0:default
org.scalameta:munit_3:1.0.0:default
org.typelevel:cats-core_3:2.9.0:default
org.typelevel:cats-effect-kernel_3:3.5.4:default
org.typelevel:cats-effect-std_3:3.5.4:default
org.typelevel:cats-effect_3:3.5.4:default
org.typelevel:cats-kernel_3:2.9.0:default
org.typelevel:munit-cats-effect_3:2.0.0:default

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, however due to the issues mentioned this is probably a better candidate for the munit-cats-effect repository?

.dependsOn(core.jvm, testkit.jvm)
.enablePlugins(MdocPlugin)
.settings(
libraryDependencies += "org.typelevel" %% "munit-cats-effect" % "2.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it would be bad practice add this dependency to the Cats Effect build. This will create a cycle: munit-cats-effect depends on cats-effect. So then we might not be able to update cats-effect without first updating munit-cats-effect, but we wouldn't be able to update munit-cats-effect without first updating cats-effect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we update first munit-cats-effect! 🧌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants