evalOnExecutor #3691
Merged
evalOnExecutor #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armanbilge @durban I do apologise for creating new branch. I somehow messed up the previous branch, so i decided to create new one. Hope for your understanding! |
|
@homycdev It's not a big problem. Btw, you don't have to merge into your PR (I think I've seen you do that on the other one), you can just push to the branch ( |
armanbilge
reviewed
Jun 14, 2023
Comment on lines
363
to
366
| * Shifts the execution of the current IO to the specified [[java.util.concurrent.Executor]]. | ||
| * | ||
| * @param executor | ||
| * @return |
There was a problem hiding this comment.
Suggested change
| * Shifts the execution of the current IO to the specified [[java.util.concurrent.Executor]]. | |
| * | |
| * @param executor | |
| * @return | |
| * Shifts the execution of the current IO to the specified [[java.util.concurrent.Executor]]. | |
| * | |
| * @see [[evalOn]] |
Comment on lines
368
to
380
| def evalOnExecutor(executor: Executor): IO[A] = { | ||
| require(executor != null, "Cannot pass undefined Executor as an argument") | ||
| executor match { | ||
| case ec: ExecutionContext => | ||
| evalOn(ec: ExecutionContext) | ||
| case executor => | ||
| IO.executionContext.flatMap { refEc => | ||
| val newEc: ExecutionContext = | ||
| ExecutionContext.fromExecutor(executor, refEc.reportFailure) | ||
| evalOn(newEc) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of duplicating the implementation :)
Suggested change
| def evalOnExecutor(executor: Executor): IO[A] = { | |
| require(executor != null, "Cannot pass undefined Executor as an argument") | |
| executor match { | |
| case ec: ExecutionContext => | |
| evalOn(ec: ExecutionContext) | |
| case executor => | |
| IO.executionContext.flatMap { refEc => | |
| val newEc: ExecutionContext = | |
| ExecutionContext.fromExecutor(executor, refEc.reportFailure) | |
| evalOn(newEc) | |
| } | |
| } | |
| } | |
| def evalOnExecutor(executor: Executor): IO[A] = | |
| IO.asyncForIO.evalOnExecutor(executor) |
durban
requested changes
Jul 4, 2023
|
The CI failure seems unrelated, I've restarted it. |
|
@armanbilge Do you want to take another look at this, or should I just merge it? |
armanbilge
approved these changes
Jul 9, 2023
|
@homycdev Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.