-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kill): should not wait too much to open a connection to ReplSet #813
fix(kill): should not wait too much to open a connection to ReplSet #813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 91.14% 91.09% -0.06%
==========================================
Files 15 15
Lines 1965 1965
Branches 494 494
==========================================
- Hits 1791 1790 -1
- Misses 165 166 +1
Partials 9 9
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once the connection spy is actually checked, this PR would be good
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Show resolved
Hide resolved
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just some semantics (some of which i wrongly suggested previously)
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-memory-server-core/src/util/__tests__/MongoInstance.test.ts
Outdated
Show resolved
Hide resolved
Marking the PR as stale, it will be closed in 7 days if no more activity is seen |
as this PR had no more activity, but the changes are still good, i will modify it myself and then merge |
🎉 This PR is included in version 9.1.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 9.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
No description provided.