Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix binary download on debian testing/unstable #787

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 16, 2023

@hasezoey
Copy link
Member

what exactly has this PR to do with the mentioned email thread?
and what exactly does this fix?

please add a test to illustrate what the change is meant to cover. tests can be found here

@orgads
Copy link
Contributor Author

orgads commented Aug 17, 2023

Updated the commit message, added tests and fixed some more cases.

Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks good to me, with some small changes

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #787 (0fe6809) into master (36bc050) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   90.38%   90.39%           
=======================================
  Files          14       14           
  Lines        1935     1937    +2     
  Branches      502      503    +1     
=======================================
+ Hits         1749     1751    +2     
  Misses        177      177           
  Partials        9        9           
Files Changed Coverage Δ
...ory-server-core/src/util/MongoBinaryDownloadUrl.ts 93.63% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hasezoey hasezoey merged commit 1a8ac8a into typegoose:master Aug 17, 2023
9 checks passed
@orgads orgads deleted the debian-testing branch August 17, 2023 11:33
@github-actions
Copy link

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs More Information released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants