Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MongoBinaryDownload): follow redirects #786

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

MattA48
Copy link

@MattA48 MattA48 commented Aug 2, 2023

Add follow-redirects library to handle 302 redirects on fastdl.mongodb.org

Related Issues

Add follow-redirects library to handle 302 redirects on fastdl.mongodb.org

re: typegoose#785
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #786 (0d81c81) into master (5fd9fd9) will decrease coverage by 0.14%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
- Coverage   90.60%   90.46%   -0.14%     
==========================================
  Files          14       14              
  Lines        1916     1920       +4     
  Branches      496      498       +2     
==========================================
+ Hits         1736     1737       +1     
- Misses        171      174       +3     
  Partials        9        9              
Files Changed Coverage Δ
...memory-server-core/src/util/MongoBinaryDownload.ts 68.42% <33.33%> (-0.92%) ⬇️
...ngodb-memory-server-core/src/util/resolveConfig.ts 93.42% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MattA48 are you fine with the changes?

@MattA48
Copy link
Author

MattA48 commented Aug 4, 2023

Looks fine to me - thanks

@hasezoey hasezoey merged commit 0d81c81 into typegoose:master Aug 4, 2023
7 of 9 checks passed
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Aug 4, 2023
@hasezoey hasezoey linked an issue Oct 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement released Pull Request released | Issue is fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to follow HTTP redirects when downloading Mongo
2 participants