Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sql types #2318

Closed
wants to merge 1 commit into from
Closed

Fixed sql types #2318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions django-stubs/db/models/sql/compiler.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ from django.db.models.sql.subqueries import AggregateQuery, DeleteQuery, InsertQ
from django.utils.functional import cached_property
from typing_extensions import TypeAlias

_ParamT: TypeAlias = str | int
_ParamT: TypeAlias = Any
Copy link
Member

@sobolevn sobolevn Aug 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole module must be revisited. There're lots of incorrect annotations there :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy that, thank you! Then I'll close the PR for now)


_ParamsT: TypeAlias = list[_ParamT]
_ParamsT: TypeAlias = tuple[_ParamT, ...]
_AsSqlType: TypeAlias = tuple[str, _ParamsT]

class PositionRef(Ref):
Expand Down
Loading