Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help returns Yargs #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tomdye
Copy link
Collaborator

@tomdye tomdye commented May 12, 2016

Fixes: Typings currently do not allow chaining of help() command.

Changes help() to return Yargs as per http://yargs.js.org/docs/#methods-helpoption-description

@blakeembrey
Copy link
Member

FWIW, this is a 4.x change - the current definition is typed to 3.31.0. It might be worth going through and tweaking other 4.x changes: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#v400-2016214-127-0700.

Would you like commit access for this?

@tomdye
Copy link
Collaborator Author

tomdye commented May 12, 2016

Thanks for the info @blakeembrey . I clearly shouldn't code into the evenings anymore! That would be good, I'm using it as part of a project so happy to update as I go / as per the 4.x changes.

@tomdye
Copy link
Collaborator Author

tomdye commented May 12, 2016

How would I go about versioning this then? Does typings typings have a process for this?

@blakeembrey
Copy link
Member

I'd add the version range in typings.json (a recent addition, but for informational purposes). When you want to publish a new release, you just open a PR on typings/registry. I'll add you as a collaborator now, I haven't been using yargs for a while now as you can tell 😄

@blakeembrey
Copy link
Member

Also, your existing PRs LGTM 👍 I'm happy for you to own this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants