Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extraContainers value #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add extraContainers value #140

wants to merge 1 commit into from

Conversation

glennpratt
Copy link

No description provided.

@glennpratt
Copy link
Author

Oops, I see this is a duplicate of #89, please review and merge that instead if possible and feel free to close this one.

If for some reason it can't land, this could be merged alone.

@Nicolas-Peiffer
Copy link

Hi, I would say that for #89, I also added support for statefulset pods.
So my PR has 2 features, it is not atomic. I should have done 2 distinct PRs.

Maybe the maintainer should merge #140 before merging #89 .

I have no opinion, since I am not a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glennpratt @Nicolas-Peiffer