Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Intraday Momentum Index (IMI) indicator #852

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

delfoxav
Copy link

I did my best to follow your nomenclature and structure. I checked and the indicator can be loaded in a strategy without any issue. I let you review it.

Kind Regards,

Xavier

@twopirllc
Copy link
Owner

Hello @delfoxav

Great! But, if you want it included, you would need to base it off the development branch. That is where all bug fixes, features and indicators happen.

Kind Regards,
KJ

@delfoxav delfoxav changed the base branch from main to development November 15, 2024 17:31
@delfoxav
Copy link
Author

Oh I see, I forked main in fact, didn't see your dev branch. Seems like I got some conflicts when trying to pull to your dev. I can probably refork your dev and deal with the conflicts on my end before submitting you another pull request.

Best,

Xavier

@twopirllc
Copy link
Owner

@delfoxav

Oh I see, I forked main in fact, didn't see your dev branch.

No worries.

... I can probably refork your dev and deal with the conflicts on my end before submitting you another pull request.

In general yes. Do look at a few other indicators in the dev branch for the updated coding style. There are better validators and the docstrings have been moved back into the functions.

KJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants