-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Intraday Momentum Index (IMI) indicator #852
base: development
Are you sure you want to change the base?
Conversation
numpy version fix twopirllc#799
Hello @delfoxav Great! But, if you want it included, you would need to base it off the development branch. That is where all bug fixes, features and indicators happen. Kind Regards, |
…sary math operations" This reverts commit 94c0b85.
Oh I see, I forked main in fact, didn't see your dev branch. Seems like I got some conflicts when trying to pull to your dev. I can probably refork your dev and deal with the conflicts on my end before submitting you another pull request. Best, Xavier |
No worries.
In general yes. Do look at a few other indicators in the dev branch for the updated coding style. There are better validators and the docstrings have been moved back into the functions. KJ |
I did my best to follow your nomenclature and structure. I checked and the indicator can be loaded in a strategy without any issue. I let you review it.
Kind Regards,
Xavier