Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twizzler crate: vec implementation of simple pushing and get #242

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Twizzler crate: vec implementation of simple pushing and get #242

merged 7 commits into from
Jan 13, 2025

Conversation

dbittman
Copy link
Contributor

This PR:

  • Adds invariant vec abstraction to the twizzler crate, with implementations of push and get.
  • Adds tests for vec
  • Fixes bugs needed to get the tests to pass

@dbittman dbittman self-assigned this Jan 10, 2025
@dbittman dbittman requested a review from gvnn3 as a code owner January 10, 2025 21:07
@dbittman dbittman force-pushed the dbittman-twizzler-crate-final-5 branch from 5d6a6de to 7a5e08e Compare January 10, 2025 22:44
gvnn3
gvnn3 approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@gvnn3 gvnn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in now.

@dbittman dbittman force-pushed the dbittman-twizzler-crate-final-5 branch 2 times, most recently from ac55aa2 to ae51602 Compare January 13, 2025 20:23
@dbittman dbittman force-pushed the dbittman-twizzler-crate-final-5 branch from ae51602 to 837d6be Compare January 13, 2025 20:26
@dbittman dbittman merged commit 01b8180 into main Jan 13, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvnn3 gvnn3 gvnn3 approved these changes

Assignees

@dbittman dbittman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbittman @gvnn3