Bridging smoltcp and tiny-http #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before finding the bug that requires client to sleep
minor change - double checking specific numbers in the code
dbittman
requested changes
Jan 10, 2025
src/bin/test-tiny-http/src/main.rs
Outdated
| handle_connection(stream); | ||
| Ok(()) | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need to keep this commented code around? If no, let's remove it
.gitmodules
Outdated
| @@ -9,3 +9,6 @@ | |||
| [submodule "src/abi"] | |||
| path = src/abi | |||
| url = ../../twizzler-operating-system/abi.git | |||
| [submodule "src/bin/src/bin/test-tiny-http/src/tiny-http-twizzler"] | |||
| path = src/bin/src/bin/test-tiny-http/src/tiny-http-twizzler | |||
| url = [email protected]:ClariseTG/tiny-http-twizzler.git | |||
There was a problem hiding this comment.
We'll need to update this to twizzler-operating-system/tiny-http-twizzler. I just moved the repo, so it should work.
changed submodule link and took out commented code in main.rs of tiny-http test
small changes in cargo.toml and lib.rs within tiny-http
update tiny-http cargo.toml
update cargo.toml and xtask build
dbittman
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes modified tiny-http as a submodule.
Modifications made to the following files:
Includes a shim that allows smoltcp sockets to be used using the Rust std::net::{TcpStream, TcpListener} interfaces.