Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twizzler crate: fill out the easy stuff, add handle caching. #236

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

dbittman
Copy link
Contributor

@dbittman dbittman commented Jan 8, 2025

This PR implements many of the 1-2 liners that were stubbed out in the previous PRs. We also add in the handle caching so we can lookup objects by pointer, which is needed for the pager.

@dbittman dbittman added the enhancement New feature or request label Jan 8, 2025
@dbittman dbittman self-assigned this Jan 8, 2025
@dbittman dbittman requested a review from gvnn3 as a code owner January 8, 2025 00:22
@dbittman dbittman force-pushed the dbittman-twizzler-crate-final-4 branch from 318a50e to 0ff0df8 Compare January 8, 2025 00:30
Copy link
Contributor

@gvnn3 gvnn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbittman dbittman merged commit 08846b6 into main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants