bump rust branch #213
Closed
bump rust branch #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can confirm it works! |
|
Ah, right, so the bump of the rust commit is blocked on me merging in another PR that I'm working on. As a work around until then, if you change the .gitmodules in rust so the backtrace URL uses https, that should work locally. Once the change that makes the newest rust commit compile is merged, i'll bump the version. This is generally how submodules (can) work -- that the actual commit is locked, and the branch can move forward. This allows independent development on the repos without causing compile errors (which is the reason just bumping the rust version here will cause the toolchain to fail to build). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay after scratching my head for a while i figured it out, turns out you have to go into the rust directory and manually change what ver is checked out. this seems a bit tedious if things are changed in the future, maybe the url's in git submodules should be changed to track the git repo / branch so this happens automatically (as far as i know this is how it should work?)