Add support for x2apic mode on amd64 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaZ3D
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Wouldn't it be better to prepend \r\n in the log macros?
There was a problem hiding this comment.
Oh, probably, but I actually have a plan to fix this at a higher level, but that'll be in some future "console I/O" PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the X2 mode of the advanced programmed interrupt controller on AMD64 machines. This is an extension to the original APIC, but on some CPU models, seems to be required. It makes programming the interrupt controller faster, too, since it allows for access to the registers via MSRs instead of MMIO.