Zphrs GetRandom - adds support for the GetRandom syscall (also adds the Instant struct to the kernel) #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbittman
reviewed
Sep 23, 2024
src/kernel/src/once.rs
Outdated
| @@ -45,7 +45,7 @@ impl<T> Once<T> { | |||
| Ordering::SeqCst, | |||
| ) { | |||
| Ok(_) => { | |||
| // We will initialize this Once. | |||
| // We willx initialize this Once. | |||
dbittman
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Some cleanup to do, there's those binary files from src/toolchain/install that need to be removed, and then extraneous debugging messages, etc. Otherwise, this looks good. Is the goal to replace the dieharder implementation with a way to extract random info out of qemu and run the tests on linux?
dbittman
reviewed
Oct 9, 2024
src/kernel/src/random/mod.rs
Outdated
| extern "C" fn contribute_entropy_regularly() { | ||
| logln!("Starting entropy contribution"); | ||
| loop { | ||
| logln!("Contributing entropy"); |
There was a problem hiding this comment.
Is this going to print every second? In general, maybe reduce some of the loglns in this file?
dbittman
requested changes
Oct 9, 2024
tools/xtask/src/qemu.rs
Outdated
| @@ -65,8 +69,13 @@ impl QemuCommand { | |||
| self.cmd | |||
| .arg("--no-reboot") // exit instead of rebooting | |||
| .arg("-s") // shorthand for -gdb tcp::1234 | |||
| .arg("-serial") | |||
| .arg("mon:stdio"); | |||
| // .arg("-serial") | |||
There was a problem hiding this comment.
We shouldn't hard code in the -smp or the -nographic.
…dom implementation rather than the userspace one
Fixed issue with loading the gitmodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See twizzler-operating-system/rfcs#12 for more details.
Justification for adding the
Instantstruct to the kernel: Since the Fortuna specification itself requires only reseeding at most every 100ms to prevent fully replacing the entropy pool with junk events (ex. events with 0s as the only bytes for the seed) within any reasonable timeframe, I required some way of keeping track of how long has passed. Additionally,Instants will be useful in the future for any timing difference based entropy sources such as timing driver events for instance.Future work:
contribute_entropyto contribute to the entropy pools.Note: Before merging this PR, make sure to first merge this one into getrandom-twizzler. Otherwise other contributors will face issues with their submodules.