Implement compartment and library API for monitor #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaZ3D
approved these changes
Sep 6, 2024
| } | ||
|
|
||
| impl super::Monitor { | ||
| /// Get CompartmentInfo for this caller. Note that this will write to the compartment-thread's |
There was a problem hiding this comment.
Why does this, and similar read-only operations, need to write into the compartment buffer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an API for accessing libraries and compartments, namely via LibraryHandle and CompartmentHandle. These types provide easy ways of opening (e.g.) the current compartment and then iterating over libraries, and then getting information about them. There are also functions for loading and managing libraries and compartments that will be implemented in the next PR.
This also updates the debug API for twizzler-runtime-api and updates gimli in rust std/backtrace to match accordingly.