Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial monitor state management overhaul #196

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Initial monitor state management overhaul #196

merged 8 commits into from
Aug 20, 2024

Conversation

dbittman
Copy link
Contributor

@dbittman dbittman commented Aug 7, 2024

This PR implements the scaffolding for the rest of the implementation of the security monitor, organizing the state management, initial support for mapping and unmapping objects in the space, and managing threads. Most of this is stubbed and not hooked up yet. Next PR will implement more functionality.

@dbittman dbittman self-assigned this Aug 7, 2024
@dbittman dbittman marked this pull request as ready for review August 7, 2024 19:22
@dbittman dbittman requested a review from gvnn3 as a code owner August 7, 2024 19:22
@dbittman dbittman added the enhancement New feature or request label Aug 7, 2024
@dbittman dbittman requested a review from PandaZ3D August 19, 2024 17:37
Copy link
Contributor

@PandaZ3D PandaZ3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor clarification.

@@ -0,0 +1,3 @@
use twizzler_runtime_api::ObjID;

pub const MONITOR_INSTANCE_ID: ObjID = ObjID::new(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a placeholder? Please document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will document!

Copy link
Contributor

@gvnn3 gvnn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it!

@dbittman dbittman merged commit 6380071 into main Aug 20, 2024
1 check passed
@dbittman dbittman deleted the dbittman-monitor branch August 20, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants