Unify ObjID types across API and ABI crates #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaZ3D
reviewed
Apr 16, 2024
Comment on lines
+56
to
+57
| /// An object ID, represented as a transparent wrapper type. Any value where the upper 64 bits are | ||
| /// zero is invalid. |
There was a problem hiding this comment.
I forget, is the rationale here that object ids with the upper 64 bits being zero are reserved by the system?
PandaZ3D
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the definition of ObjID in twizzler-abi into twizzler-runtime-api, so that the low-level object ID type is a) the same across all crates, for ergonomics, and b) is available to even the lowest level runtime code.
The vast majority of changes in this PR are removing no-longer-needed type conversions between the previously different ObjID types.
This will significantly improve the ergonomics of working with object IDs.