-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic secure gate infrastructure #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is going to be an odd request. Can you not call it hello_world? That's always considered a demo program to do printf("Hello world"). I'd call it hello_gate(way) so that we're specific of what it's doing and testing.
Yup, makes sense. Had originally intended to remove this for the PR but forgot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR continues towards secure gates, implementing the following:
This is pretty limited right now in terms of the types that can be passed and the functions that can be made into secure gates, and it does not currently do any security enforcement. This PR is about getting rust itself on board with this nonsense :)
A side effect that is noteworthy is that we now set CC and CFLAGS env vars in xtask so that crates that compile C code can do so with our patched clang.