Fix deadlock in priority donation code.

Drop the spinlock before calling maybe_reschedule_thread.
twizzler-operating-system · Nov 8, 2024 · b7ebdb3 · b7ebdb3
1 parent 7f1bd3b
commit b7ebdb3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/kernel/src/thread/priority.rs b/src/kernel/src/thread/priority.rs
@@ -135,6 +135,7 @@ impl Thread {
         self.flags
             .fetch_and(!THREAD_HAS_DONATED_PRIORITY, Ordering::SeqCst);
         *donated_priority = None;
+        drop(donated_priority);
         if current_priority < self.effective_priority() {
             self.maybe_reschedule_thread();
         }
@@ -167,6 +168,7 @@ impl Thread {
         *donated_priority = Some(pri);
         self.flags
             .fetch_or(THREAD_HAS_DONATED_PRIORITY, Ordering::SeqCst);
+        drop(donated_priority);
         if needs_resched {
             if let Some(cur) = current_thread_ref() {
                 if cur.id() == self.id() {