Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Fixes/for upstream #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Commits on Apr 18, 2016

  1. Add period values for 'sec' and 'ms' granularities, as it appears the…

    …y are missing.
    
    If the granularity detection results in "sec" or "ms" granularity
    detect_anons will blow up with a message stating 'period' was not
    provided. Which is correct. This provides at least some defaults.
    
    This is a bit tricky, since the number of samples really isn't guaranteed
    to to be 1 measurement per whatever the 'gran' variable says it is.
    However, this code appears to assume that. Leading to "fun" when the
    precision is in ms but the measurements fire a lot less often - say, once
    per five minutes (that's the testcase in question).
    
    There are two ways to deal with this, neither of them implemented by this patch:
    - Look at the delta between the first and the last timestamp and the number
    of records and make an educated guess from there.
    - Add 'period' as a function argument and let the caller decide, using the
    hardcoded values simply as educated guesses.
    
    These approaches can be combined, but that is left as an exercise for the reader.
    randakar committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    82a762a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b58b8bb View commit details
    Browse the repository at this point in the history