-
-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
565: feat: fixed for the issue (#556) r=myConsciousness a=myConsciousness # 1. Description <!-- Provide a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If this is a breaking change, specify explicitly which APIs have been changed. --> ## 1.1. Checklist <!-- Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. --> - [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc). - [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs. - [x] I have updated/added tests for ALL new/updated/fixed functionality. - [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`. - [x] I have updated/added relevant examples in `examples`. ## 1.2. Breaking Change <!-- Does your PR require users to manually update their apps to accommodate your change? If the PR is a breaking change this should be indicated with suffix "!" (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details. --> - [ ] Yes, this is a breaking change. - [x] No, this is _not_ a breaking change. ## 1.3. Related Issues <!-- Provide a list of issues related to this PR from the [issue database]. Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !--> <!-- Links --> [issue database]: https://github.com/twitter-dart/twitter-api-v2/issues [contributor guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/CONTRIBUTING.md [style guide]: https://github.com/twitter-dart/twitter-api-v2/blob/main/STYLEGUIDE.md [conventional commit]: https://conventionalcommits.org Co-authored-by: myConsciousness <[email protected]>
- Loading branch information
Showing
7 changed files
with
157 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
lib/src/service/tweets/filtering/operator/standalone/context.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// Copyright 2022 Kato Shinya. All rights reserved. | ||
// Redistribution and use in source and binary forms, with or without | ||
// modification, are permitted provided the conditions. | ||
|
||
// Project imports: | ||
import '../operator.dart'; | ||
import '../validation_result.dart'; | ||
|
||
class Context extends Operator { | ||
/// Returns the new instance of [Context]. | ||
const Context( | ||
this.value, { | ||
bool negated = false, | ||
}) : super(negated); | ||
|
||
factory Context.negated(final String value) => Context(value, negated: true); | ||
|
||
/// The value | ||
final String value; | ||
|
||
@override | ||
ValidationResult validate() { | ||
if (value.isEmpty) { | ||
return ValidationResult.failed( | ||
'The context must not be an empty string.', | ||
); | ||
} | ||
|
||
return ValidationResult.succeeded(); | ||
} | ||
|
||
@override | ||
String format() => 'context:$value'; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
test/src/service/tweets/filtering/operator/standalone/context_test.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright 2022 Kato Shinya. All rights reserved. | ||
// Redistribution and use in source and binary forms, with or without | ||
// modification, are permitted provided the conditions. | ||
|
||
// Package imports: | ||
import 'package:test/test.dart'; | ||
import 'package:twitter_api_v2/src/service/tweets/filtering/operator/standalone/context.dart'; | ||
|
||
void main() { | ||
group('.toString', () { | ||
test('with string value', () { | ||
final actual = Context('10.799022225751871488'); | ||
|
||
expect(actual.toString(), 'context:10.799022225751871488'); | ||
}); | ||
|
||
test('when negated', () { | ||
final actual = Context.negated('domain_id.*'); | ||
|
||
expect(actual.toString(), '-context:domain_id.*'); | ||
}); | ||
|
||
test('when value is empty', () { | ||
final actual = Context(''); | ||
|
||
expect( | ||
() => actual.toString(), | ||
throwsA( | ||
allOf( | ||
isA<ArgumentError>(), | ||
predicate( | ||
(dynamic e) => | ||
e.message == 'The context must not be an empty string.', | ||
), | ||
), | ||
), | ||
); | ||
}); | ||
}); | ||
} |