This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Add support for specifying ParrotRequest body as a ByteArrayInputStream #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sending parrot requests with a body that are to be interpreted as Content-Type: application/octet-stream.
| httpRequest.setHeader(CONTENT_LENGTH, buffer.readableBytes) | ||
| httpRequest.setContent(buffer) | ||
| if ((request.method == "POST" || request.method == "PUT") && | ||
| (request.bodyInputStream.isDefined || request.body.length > 0)) { |
There was a problem hiding this comment.
Why do we have request.bodyInputStream.isDefined -- what does it do that request.body.length > 0 doesn't? Is it that we want to support zero length messages?
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows sending parrot requests with a body that are to be interpreted as Content-Type: application/octet-stream.
The choice of requiring a ByteArrayInputStream vs any InputStream was simply because it made the allocation of the ChannelBuffer simple, because then InputStream.available() can be used reliably, and in favor over more complex allocation/copying of the InputStream to a Netty ChannelBuffer.