refactor: use snapshot tests #475
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
refactor/snapshot-tests
branch
2 times, most recently
from
38b2695 to
8e7ec49
Compare
Emilgardis
force-pushed
the
refactor/snapshot-tests
branch
from
536602c to
8ed4d5a
Compare
Emilgardis
force-pushed
the
refactor/snapshot-tests
branch
from
8ed4d5a to
625faa2
Compare
|
Changed the code to use inline snapshot storage instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #457 (review). This refactors tests to use
insta. It's more of a proof of concept, so I don't waste too much time. Feel free to push to this.The names of the snapshots are a bit long for my taste (https://redirect.github.com/mitsuhiko/insta/issues/377).