Parse coordinates correctly #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleXMLElements has no "length" property, but it has a count() function: http://php.net/manual/en/simplexmlelement.count.php Also the xpath expression didn't work correctly so that was fixed as well. close #25
|
As stated for the other clients, we want lat/long on the Post object. I know you are on it. :) |
This way latitude and longitude is always set. If the post has no coordinates, latitude and longitude will be null. Also downcased "NULL" in one place so we only use "null".
dentarg
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleXMLElements has no "length" property, but it has a count() function: http://php.net/manual/en/simplexmlelement.count.php
Also the xpath expression didn't work correctly so that was fixed as well.
close #25
close #27