Use box-shadow instead of drop-shadow to improve rendering performance in Safari.
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmance in Safari.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
角が残ってしまうなどいろいろ不具合があるが、Safari のページが重すぎて離脱が激しいリスクを鑑みて、一旦 Merge したい |
takonasu
approved these changes
Apr 1, 2023
| 48.888px 48.888px 83.808px rgba(194, 203, 207, 0.25); | ||
| } | ||
|
|
||
| @mixin box-shadow-screen-primary { |
There was a problem hiding this comment.
今回は使われていないものの、もともと $box-shadow-screen-primary が定義されていたので、それに対応する @mixin を一応残しました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #81
drop-shadowとbox-shadowはアルゴリズムが違う可能性があるので注意が必要だが、今回はdrop-shadowと同じプロパティを指定するとそっくりの見た目になった