授業編集時に空文字が担当教員欄に入りバリデーションエラーになるバグを修正 #753
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HosokawaR
force-pushed
the
hotfix/course-editing-submit-button-activating
branch
from
0e61e16
to
49bf341
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
※ develop は V4 の開発をしているので main に向けています。
背景
BE では担当教員がいないことを
""で扱っている一方で、FE では担当教員欄の空文字は許可していない。そのためバリデーションに通らず保存ボタンが活性化しない。
このことがユーザにとっては「なぜかわからないが保存ボタンが押せない」という状況に繋がり混乱させている。
対策
もっとも簡単にできる処置として BE の
""を FE で受け取るさいに[]に変換した。理想的には以下のような手段を取るべきだが、時間がなかったため。
[]で扱う動作確認
Before
空欄のフィールドが生成されており、保存ボタンが活性化しない
After
担当教員がいない場合はちゃんとフィールドが 0 個になっており、保存ボタンを押せる