Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #663 local jump error due to lack of block passing for recording list #665

Conversation

JYorston
Copy link
Contributor

@JYorston JYorston commented Jun 16, 2023

Fix local jump error due to lack of block passing for recording list.

Fixes
#663

It appears after a recent merge that the block passed to the seralize_list method was removed in the recordings file:
JYorston@1956b94

This is causing a local_jump_error when trying to list recordings on the latest Gem version.

I added the block back in and verified that it is now working as expected.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Fix local jump error due to lack of block passing for recording list
Copy link
Contributor

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that these are auto-generated files via our internal oai-generator, which would need modifications to incorporate this change in next generations. Tracked via DII-1038.

To unblock you in development usage, I can approve this change for now. Please wait till the next release for the fix to be available in sdk.

@shrutiburman shrutiburman merged commit 0230689 into twilio:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants