Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHP 8.4 Take 3 #844

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: PHP 8.4 Take 3 #844

wants to merge 5 commits into from

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Jan 25, 2025

Fixes

While #839 fixed the non-generated code, the generated code still has the problem of typed parameters with a null default value. This produces depreciation messages in PHP 8.4

This PR adds the PHP CS Fixer and configuration so that the generated code can be automatically updated to be PHP 8.4 compatible.

I was unable to find the place where the code is generated by https://openapi-generator.tech, so this PR will need additional work to automatically update the code after generation.

To fix the generated code, just enter this command:

composer run-script php84-fix

The resulting code should then be checked into the repo. This should be able to be automated and run immediately after code generation.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant