Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue with statusCallbackEvent argument type #798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix issue with statusCallbackEvent argument type
andreascreten authored Mar 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit d61d3c6559bd3ef244638813d08f3abd7f63290f
5 changes: 3 additions & 2 deletions src/Twilio/TwiML/Voice/Number.php
Original file line number Diff line number Diff line change
@@ -52,9 +52,10 @@ public function setMethod($method): self {
/**
* Add StatusCallbackEvent attribute.
*
* @param string[] $statusCallbackEvent Events to call status callback
* @param string[]|string $statusCallbackEvent Events to call status callback
*/
public function setStatusCallbackEvent($statusCallbackEvent): self {
$statusCallbackEvent = is_array($statusCallbackEvent) ? implode(' ', $statusCallbackEvent) : $statusCallbackEvent;
return $this->setAttribute('statusCallbackEvent', $statusCallbackEvent);
}

@@ -155,4 +156,4 @@ public function setMachineDetectionSpeechEndThreshold($machineDetectionSpeechEnd
public function setMachineDetectionSilenceTimeout($machineDetectionSilenceTimeout): self {
return $this->setAttribute('machineDetectionSilenceTimeout', $machineDetectionSilenceTimeout);
}
}
}