Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added domain_name as a computed output variable to the Serverless #88

Closed
wants to merge 2 commits into from
Closed

feat: Added domain_name as a computed output variable to the Serverless #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7453f25
Added domain_name as a computed output variable to the Serverless
stephenhand Jan 7, 2022
8ed38bf
Updated docs for new serverless environment output variable
stephenhand Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions twilio/resources/serverless/v1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Name | Type | Requirement | Description
**unique_name** | string | **Required** | A user-defined string that uniquely identifies the Environment resource. It can be a maximum of 100 characters.
**domain_suffix** | string | Optional | A URL-friendly name that represents the environment and forms part of the domain name. It can be a maximum of 16 characters.
**sid** | string | *Computed* | The SID of the Environment resource to fetch.
**domain_name** | string | *Computed* | The domain name generated for use by external callers to reach functions running in this environment, e.g. 'myservice-1234-myenvironment.twil.io'.

## twilio_serverless_services_functions_v1

Expand Down
1 change: 1 addition & 0 deletions twilio/resources/serverless/v1/api_default.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions twilio/resources_serverless_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func TestAccServerlessSetup_basic(t *testing.T) {
resource.TestCheckResourceAttr(serverlessSvcResourceName, "unique_name", serviceName),
resource.TestCheckResourceAttr(serverlessSvcFuncResourceName, "friendly_name", "Serverless func"),
resource.TestCheckResourceAttr(serverlessSvcEnvResourceName, "unique_name", "environment-dummy"),
resource.TestCheckResourceAttrSet(serverlessSvcEnvResourceName, "domain_name"),
),
},
{
Expand All @@ -49,6 +50,7 @@ func TestAccServerlessSetup_basic(t *testing.T) {
resource.TestCheckResourceAttr(serverlessSvcResourceName, "unique_name", serviceName),
resource.TestCheckResourceAttr(serverlessSvcFuncResourceName, "friendly_name", "Serverless func 2"),
resource.TestCheckResourceAttr(serverlessSvcEnvResourceName, "unique_name", "environment-dummy-updated"),
resource.TestCheckResourceAttrSet(serverlessSvcEnvResourceName, "domain_name"),
testAccEnvResourceWasRecreated(&serviceBefore, &serviceAfter),
),
},
Expand Down