Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added domain_name as a computed output variable to the Serverless #88

Closed
wants to merge 2 commits into from
Closed

feat: Added domain_name as a computed output variable to the Serverless #88

wants to merge 2 commits into from

Conversation

stephenhand
Copy link

@stephenhand stephenhand commented Jan 7, 2022 •
edited
Loading

Resolves #85

Adds a domain_name output variable to the Serverless Environment resource. This can then be passed to other resources that need to be configured to call the functions deployed in this environment.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [?] I have read the Contribution Guidelines and my PR follows them - that is a dead link?
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • [N/A] I have added inline documentation to the code I modified

shwetha-manvinkurke
shwetha-manvinkurke reviewed Jan 14, 2022
View reviewed changes
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are auto-generated fields and this change needs to happen in the generator. That said, we have this issue in our backlog and we will be working on fixing it in the near future.

@stephenhand
Copy link
Author

These are auto-generated fields and this change needs to happen in the generator. That said, we have this issue in our backlog and we will be working on fixing it in the near future.

Ok, thanks for the update! Could you perhaps provide some guidance about the nature of this repo and how it is produced & maintained in the contributing docs to assist future contributors?

Unless it's already there and I missed it, in which case nm!

@janorivera
Copy link

@shwetha-manvinkurke Hi, I was wondering if this got fixed. 9 months after the issue was raise seems to me like the "near future".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetha-manvinkurke shwetha-manvinkurke shwetha-manvinkurke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Featiure Request: Add domain output variable to serverless environment resource
3 participants
@stephenhand @janorivera @shwetha-manvinkurke