Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/for signal #193

Merged
merged 62 commits into from
Nov 8, 2024
Merged

Fix/for signal #193

merged 62 commits into from
Nov 8, 2024

Conversation

IObert
Copy link
Collaborator

@IObert IObert commented Oct 31, 2024

No description provided.

Copy link
Collaborator

@nokenwa nokenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tried to go through as much as I could. I haven't got Segment integration set up so wasn't able to test that

Copy link
Collaborator

@nokenwa nokenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nokenwa nokenwa merged commit 71eea1b into main Nov 8, 2024
1 check passed
@IObert IObert deleted the fix/forSignal branch November 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants