Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(@twilio/runtime-handler): revert package.json #511

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

makserik
Copy link
Contributor

@makserik makserik commented Mar 20, 2024

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: b9ee570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

const mod2 = require('@twilio/test-dep');
expect(mod2['__TYPE__']).toBe('BUILT_IN');
});
// npm hoists the package to root node_modules making this test not possible currently
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this comments here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a reminder to uncomment it when we migrate off npm

@makserik makserik merged commit 21418aa into twilio-labs:main Mar 20, 2024
10 checks passed
expect(mod2['__TYPE__']).toBe('BUILT_IN');
});
// npm hoists the package to root node_modules making this test not possible currently
// test('should return project based by default', () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use test.skip as well ?
No need to comment everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants