-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(@twilio/runtime-handler): revert package.json #511
Conversation
|
const mod2 = require('@twilio/test-dep'); | ||
expect(mod2['__TYPE__']).toBe('BUILT_IN'); | ||
}); | ||
// npm hoists the package to root node_modules making this test not possible currently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this comments here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a reminder to uncomment it when we migrate off npm
expect(mod2['__TYPE__']).toBe('BUILT_IN'); | ||
}); | ||
// npm hoists the package to root node_modules making this test not possible currently | ||
// test('should return project based by default', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use test.skip
as well ?
No need to comment everything
Contributing to Twilio