feat(model): Add associated types to CommandOption(Value). #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds associated types for the integer and floating point range that is allowed. It also adds a range that contains the allowed length of a string. Closes #2402
github-actions
bot
added
c-model
khionu
reviewed
Jan 30, 2025
khionu
approved these changes
Feb 6, 2025
Gelbpunkt
approved these changes
Feb 7, 2025
AEnterprise
approved these changes
Feb 9, 2025
Erk-
deleted the
erk/feat/model/associated-constants-on-command-option-type
branch
viztea
pushed a commit
to eara-bot/twilight
that referenced
this pull request
Feb 15, 2025
…rs#2415) This commit adds associated types for the integer and floating point range that is allowed. It also adds a range that contains the allowed length of a string. Closes twilight-rs#2402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds associated types for the integer and floating point range that is allowed.
It also adds a range that contains the allowed length of a string.
Closes #2402