fix(model, cache): unavailable is optional and false and none equal #2377
+40
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unavailable would assume false if the field was false if it was not sent. The ability to tell the difference can be used to tell the difference between a guild becoming available and joining a new guild. Resolves #2372
github-actions
bot
added
c-cache
vilgotf
requested changes
Oct 5, 2024
There was a problem hiding this comment.
I think twilight_model::gateway::payload::incoming::GuildDelete is affected too1:
Sent when a guild becomes or was already unavailable due to an outage, or when the user leaves or is removed from a guild. The inner payload is an unavailable guild object. If the unavailable field is not set, the user was removed from the guild.
Footnotes
As the helpful comment we have says
Erk-
force-pushed
the
erk/fix/resolve-guild-avail-ambiguity
branch
from
550ff45
to
96b027b
Compare
AEnterprise
approved these changes
Oct 20, 2024
itohatweb
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unavailable would assume false if the field was false if it was not sent.
The ability to tell the difference can be used to tell the difference between a guild becoming available and joining a new guild.
Resolves #2372