fix(model): Unavailable guild must always have unavailable as true #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-model
laralove143
reviewed
Jul 20, 2024
| Unavailable(UnavailableGuild), | ||
| Available(Guild), |
There was a problem hiding this comment.
is the ordering intentionally changed
There was a problem hiding this comment.
Yes, as a available guild can't be parsed as a unavailable guild anymore.
There was a problem hiding this comment.
so here, the ordering of the enum is semantically significant? does serde try to deserialize each variant in order?
There was a problem hiding this comment.
Yes serde will try them in order when it is untagged.
This adds a new construct that can be used to only deserialize a specific boolean value. We then use that value to ensure that only guilds which are actually unavailable get deserialized as such.
Erk-
force-pushed
the
erk/fix-guild-create
branch
from
8ec9aec
to
3f417fe
Compare
Signed-off-by: Jens Reidel <[email protected]>
Signed-off-by: Jens Reidel <[email protected]>
Gelbpunkt
approved these changes
Sep 4, 2024
Signed-off-by: Jens Reidel <[email protected]>
Signed-off-by: Jens Reidel <[email protected]>
AEnterprise
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new construct that can be used to only deserialize a
specific boolean value. We then use that value to ensure that only
guilds which are actually unavailable get deserialized as such.