Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models): add "flags" field to MemberUpdate payload #2265

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kelwing
Copy link
Contributor

@Kelwing Kelwing commented Aug 21, 2023

Adds the flags field to the MemberUpdate gateway model. Discord sends this field, but it is not captured by Twilight, and is incredibly useful when working with servers that have onboarding enabled.

@github-actions github-actions bot added the c-model Affects the model crate label Aug 21, 2023
@Kelwing Kelwing changed the title Add "flags" field to MemberUpdate payload fix(models): add "flags" field to MemberUpdate payload Aug 21, 2023
@github-actions github-actions bot added the t-fix Fixes a bug in the library label Aug 21, 2023
@itohatweb
Copy link
Member

Looks like this field is also not documented by Discord (https://discord.com/developers/docs/topics/gateway-events#guild-member-update)

@Kelwing
Copy link
Contributor Author

Kelwing commented Aug 27, 2023

No it is not, but it is most definitely sent, and is analogous to the one in the Member object.

@Erk- Erk- added the d-api Change related to Discord's API. label Dec 29, 2023
@Erk-
Copy link
Member

Erk- commented Dec 29, 2023

I think we should see if they want to add it to the documentation before we look into adding it here.

@Erk-
Copy link
Member

Erk- commented Mar 17, 2024

I have opened a PR against the Discord docs to get this added: discord/discord-api-docs#6717

@laralove143 laralove143 added the w-do-not-merge PR is blocked or deferred label Mar 17, 2024
@Erk- Erk- removed the w-do-not-merge PR is blocked or deferred label May 15, 2024
@Erk-
Copy link
Member

Erk- commented May 15, 2024

@Kelwing Discord have accepted my pr, do you have anything aginst rebasing this, then we can merge it.

@github-actions github-actions bot added the c-cache Affects the cache crate label Nov 17, 2024
@itohatweb
Copy link
Member

@Kelwing @Erk- I have rebased the PR and also wrapped flags in an Option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-cache Affects the cache crate c-model Affects the model crate d-api Change related to Discord's API. t-fix Fixes a bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants