Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http): fix get invite query params #2256

Merged
merged 3 commits into from
Sep 10, 2023

Conversation

Jack073
Copy link
Contributor

@Jack073 Jack073 commented Aug 5, 2023

Currently the GetInvite with_counts() and with_expiration() don't work as the query string they append uses - instead of _ in the keys, as specified in the API docs - https://discord.com/developers/docs/resources/invite#get-invite-query-string-params.

@github-actions github-actions bot added c-http Affects the http crate t-fix Fixes a bug in the library labels Aug 5, 2023
@Jack073
Copy link
Contributor Author

Jack073 commented Aug 5, 2023

Apologies for adding a commit after, I just saw that as well when I was playing with my bot.

twilight-http/src/routing.rs Outdated Show resolved Hide resolved
@Gelbpunkt Gelbpunkt merged commit 1a8fb4e into twilight-rs:main Sep 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-http Affects the http crate t-fix Fixes a bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants