Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gateway): remove ratelimiter sleep from new #2232

Merged
merged 3 commits into from
Jul 2, 2023
Merged

refactor(gateway): remove ratelimiter sleep from new #2232

merged 3 commits into from
Jul 2, 2023

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Jul 1, 2023

This timer registration hack is slightly less horrible.

@github-actions github-actions bot added c-gateway Affects the gateway crate t-refactor Refactors APIs or code. labels Jul 1, 2023
HTGAzureX1212
HTGAzureX1212 approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HTGAzureX1212 HTGAzureX1212 self-requested a review July 2, 2023 05:40
@vilgotf vilgotf merged commit 7a1888d into main Jul 2, 2023
10 checks passed
@vilgotf vilgotf deleted the vilgotf/gateway/ratelimiter-reset-hack branch July 2, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HTGAzureX1212 HTGAzureX1212 HTGAzureX1212 approved these changes

Assignees
No one assigned
Labels
c-gateway Affects the gateway crate t-refactor Refactors APIs or code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilgotf @HTGAzureX1212