docs(gateway): cleanup reshard example #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gelbpunkt
reviewed
Jul 18, 2023
examples/gateway-reshard.rs
Outdated
| let mut stream = ShardMessageStream::new(shards.iter_mut()); | ||
|
|
||
| // Drive the new list of shards until they are all identified. | ||
| while !identified.iter().all(|&shard| shard) { | ||
| while identified.iter().sum::<usize>() < (identified.len() * 3) / 4 { |
There was a problem hiding this comment.
We should also be able to employ some better heuristics here if we want to take it further. Since we already call the get gateway endpoint, we can calculate the estimated time until which the shards should be identified. We could combine a sleep for that with the 75% identified goal to avoid returning a bit too early. Not sure how much benefit that little bit of added complexity would bring though.
vilgotf
commented
Jul 19, 2023
examples/gateway-reshard.rs
Outdated
Comment on lines
144
to
145
| + (1..refills).map(|_| DAY).sum::<Duration>() | ||
| + Duration::from_secs(5 * buckets % total as u64) |
There was a problem hiding this comment.
These constants can be replaced by twilight-gateway-queue once #2228 lands
Gelbpunkt
approved these changes
Dec 9, 2023
Removes irrelevant code & comments.
Gelbpunkt
force-pushed
the
vilgotf/docs/cleanup-gateway-reshard
branch
from
d37acb5
to
6771df2
Compare
Erk-
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes irrelevant code & comments and improves identified heuristics.