perf(gateway): reuse ratelimiter's cleanup instant #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pruning of elapsed permits after the sleep timer's elapsed requires the current time, however, this involves a syscall, so let's reuse it.
Let's do the calculation for the user & move it to DEBUG as it's now human readable.
github-actions
bot
added
c-gateway
vilgotf
force-pushed
the
vilgotf/gateway/perf/ratelimiter
branch
from
a81e7a2
to
875b665
Compare
vilgotf
force-pushed
the
vilgotf/gateway/perf/ratelimiter
branch
from
9518b85
to
6166c87
Compare
Gelbpunkt
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short and simple micro-optimization that removes a syscall from
CommandRatelimiter::poll_ready+ some minor cleanup.