feat(validate, http)!: add regex_patterns and allow_list
#2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-rs#2161) Add support for the new `custom_message` field available on AutoMod `BLOCK_MESSAGE` actions. Discord API Docs: discord/discord-api-docs#5955 (cherry picked from commit 94ab90d)
github-actions
bot
added
c-http
…ation # Conflicts: # twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs # twilight-validate/src/request.rs
HTGAzureX1212
changed the title
regex_patterns and allow_listregex_patterns and allow_list
HTGAzureX1212
approved these changes
Jun 18, 2023
laralove143
requested changes
Jun 21, 2023
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
twilight-http/src/request/guild/auto_moderation/create_auto_moderation_rule.rs
Show resolved
Hide resolved
|
In my opinion it is a bit too much for this pr. Also rewriting all this would probably take me a lot of time because I'm not that familiar with this crate. |
|
thats ok, we can merge this and create another pr for those changes |
baptiste0928
approved these changes
Jun 25, 2023
laralove143
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds regex_patterns and allow_list when creating a auto moderation rule, as well as validation for most fields.
I'm pretty new to rust and this crate, so please provide lots of feedback, thanks :D