-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: object activate dropdown #8438
fix: object activate dropdown #8438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Simplified the dropdown menu structure in Settings Object Inactive Menu by removing redundant DropdownMenu wrapper while maintaining core functionality.
- Removed unnecessary
DropdownMenu
wrapper in/packages/twenty-front/src/modules/settings/data-model/objects/components/SettingsObjectInactiveMenuDropDown.tsx
to fix activation button bug - Preserved conditional rendering of delete option for custom objects
- Maintained proper dropdown scope and hotkey handling
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
@harshrajeevsingh we should match width to figma, thanks ;) @Bonapara its called erase and not delete in figma :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good --- just need to adjust width
Good catch thanks! Same as here: https://github.com/twentyhq/twenty/pull/8374/files Would you wind also correcting it here? (need to un hide this in your .env)
|
@FelixMalfait There are even more components with A few of them can't be seen because they are the same width. |
I will take care of MessageThreadSubscribersDropdownButton |
@ehconitin All set on my end! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thank you!
Fixes: #8436
Fixes: #8435
& other duplicate
DropdownMenu