Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soft deleted records are read only #8198

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pau-not-paul
Copy link
Contributor

@pau-not-paul pau-not-paul commented Oct 30, 2024

TODO:

  • It should not be possible to add tasks, notes, files, etc.

Fix for #7172

Note for reviewer:

  • With these changes, deletedAt is now always included in recordGqlFields.

@FelixMalfait
Copy link
Member

Let's go with this approach! but we need to disable additional items:

-> List view
Screenshot 2024-10-30 at 14 09 05

-> Ability to create relation, tasks, etc.
Screenshot 2024-10-30 at 14 09 26

@FelixMalfait
Copy link
Member

/award 500

Copy link

oss-gg bot commented Oct 30, 2024

Awarding pau-not-paul: 500 points 🕹️ Well done! Check out your new contribution on oss.gg/pau-not-paul

@pau-not-paul pau-not-paul force-pushed the fix/soft-deleted-records-are-read-only branch from 0f166da to a2d53b3 Compare October 30, 2024 14:01
@pau-not-paul pau-not-paul marked this pull request as draft October 30, 2024 14:10
@pau-not-paul pau-not-paul force-pushed the fix/soft-deleted-records-are-read-only branch 4 times, most recently from 8548ecf to f029e44 Compare October 30, 2024 16:29
@pau-not-paul pau-not-paul force-pushed the fix/soft-deleted-records-are-read-only branch from f029e44 to b64611c Compare October 30, 2024 17:34
@pau-not-paul pau-not-paul marked this pull request as ready for review October 30, 2024 18:10
@pau-not-paul pau-not-paul marked this pull request as draft October 30, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants