-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): fix export map types #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resolved the typing error. Could someone please merge.
This will be handled soon as part of Besides it won't make sense to point both ESM and CommonJS files to the same type definitions. So in #655 we'll work on this next first thing, simplify the output, moving onto only ES Modules so we avoid the need to have a more complicated configuration. In the meantime, anyone who wants to try @tazyong's branch can install Tween.js like this: npm install @tweenjs/tween.js@git@github:tazyong/tween.js#package-health or put this inside "dependencies": {
"@tweenjs/tween.js": "github:tazyong/tween.js#package-health"
} |
package.json
Outdated
@@ -8,8 +8,14 @@ | |||
"module": "dist/tween.esm.js", | |||
"exports": { | |||
".": { | |||
"import": "./dist/tween.esm.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any update on this issue? |
Here is a minimal tsconfig.json to reproduce this problem. {
"compilerOptions": {
"module": "ES2015",
"noImplicitAny": true,
"moduleResolution": "bundler" // or "node16"
}
}
I hope this record helps someone. |
Thanks @MasatoMakino. Will circle to this soon, this week. |
Hey @trusktr this is a pretty rough for TypeScript users, since TypeScript doesn't think there are any types for modern Looking forward to this getting resolved. :) |
The types have been recently added from the other PR (the one-liner as @july-12 mentioned above)! |
Thank you for the contribution! |
Fix import error in typescript