Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Manage Emulators automatically #55
base: main
Are you sure you want to change the base?
WIP: Manage Emulators automatically #55
Changes from 8 commits
20fa014
483fe35
9d9c325
4690b62
84808d8
cb8abd2
fe2d0ed
2119d02
af01e7c
fbd378e
df9f489
9250b58
6e2b52f
4cbf2ab
9340ee4
1471ddf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handling
EmulatorError
isn't enough. Here's what I got when closing the emulator during an analysis (having added anelse throw error;
):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recovery from broken snapshots doesn't seem to be handled. I deleted the snapshot (by deleting the folder in
~/.android/avd/cyanoacrylate-examples-multiple-apps-9a2f000670072430e8fe9f968a2a1d15.avd/snapshots
) while an analysis was running. The analysis for the current app finished without issues, but every subsequent app failed:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After restarting the analysis program, it did recover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue when corrupting the emulator itself by deleting
userdata-qemu.img
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one didn't even recover after restarting the analysis program:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snapshot does exist though, despite the error message:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, figures. If adb realizes that the snapshot is broken before it sends it off to the emu, it doesn’t register an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that need a specific emu version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, at least for your version, this should be available, according to the documentation close to the release date. I am using
35.2.10.0
, though. Have you set the correctANDROID_HOME
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snippet above was using my system emu (with correct
ANDROID_HOME
). Doesn't work with the andromatic one, either:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the docs are wrong then. Just tested on my Macbook where I have version 32 as well and got the same error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying an AVD name as in the docs you linked starts the emu and doesn't list the snapshots:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s hard to tell, there is a
-no-snapstorage
options, but I don’t care to test this. I guess I’ll just use the folders as a fallback?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But again, there is no way to pass to pass any of these options to CA anyway, is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, no. We also don’t use this function right now, so maybe I shouldn’t care really? As I said in the comment, I don’t know if I really want to introduce the added complexity of snapshot management anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you included most of that already, how much more is there to do? Also, we decided to move the honey data automation from cli to CA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be addressed.