Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency aspect_rules_js to v2 #2230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update dependency aspect_rules_js to v2 #2230

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 15, 2024 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
aspect_rules_js bazel_dep major 1.42.3 -> 2.0.1
aspect_rules_js http_archive major v1.42.3 -> v2.0.1

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

aspect-build/rules_js (aspect_rules_js)

v2.0.1

Compare Source

Many companies are successfully building with rules_js.
If you're getting value from the project, please let us know!
Just comment on our Adoption Discussion.

Using Bzlmod with Bazel 6:

Add to your MODULE.bazel file:

bazel_dep(name = "aspect_rules_js", version = "2.0.1")

####### Node.js version #########

### By default you get the node version from DEFAULT_NODE_VERSION in @​rules_nodejs//nodejs:repositories.bzl
### Optionally you can pin a different node version:
bazel_dep(name = "rules_nodejs", version = "6.2.0")
node = use_extension("@​rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
node.toolchain(node_version = "16.14.2")

#################################

npm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)

npm.npm_translate_lock(
    name = "npm",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

use_repo(npm, "npm")

pnpm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "pnpm")

### Allows developers to use the matching pnpm version, for example:
### bazel run -- @​pnpm --dir /home/runner/work/rules_js/rules_js install
use_repo(pnpm, "pnpm")

Using WORKSPACE

Paste this snippet into your WORKSPACE file:

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_rules_js",
    sha256 = "4cab6898f0ff8048e32640cce06a47aa4b92b2fb330d055940f95f24c8ebb868",
    strip_prefix = "rules_js-2.0.1",
    url = "https://github.com/aspect-build/rules_js/releases/download/v2.0.1/rules_js-v2.0.1.tar.gz",
)

load("@​aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@​aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@​aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

npm_translate_lock(
    name = "npm",
    npmrc = "//:.npmrc",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

load("@​npm//:repositories.bzl", "npm_repositories")

npm_repositories()

What's Changed

Full Changelog: aspect-build/rules_js@v2.0.0...v2.0.1

v2.0.0

Compare Source

This is our first semver-major release since 1.0 and has some breaking changes.
These are documented in the rules_js 2.0 migration guide.
Note that you'll need to upgrade other rules that depend on rules_js at the same time.

There is a known issue with usage on Windows: https://github.com/aspect-build/rules_js/issues/1739
If you use rules_js on Windows we'd love to know about it. Having active users justifies prioritizing the fix.

Using Bzlmod (recommended):

Add to your MODULE.bazel file:

bazel_dep(name = "aspect_rules_js", version = "2.0.0")

####### Node.js version #########

### By default you get the node version from DEFAULT_NODE_VERSION in @​rules_nodejs//nodejs:repositories.bzl
### Optionally you can pin a different node version:
bazel_dep(name = "rules_nodejs", version = "6.2.0")
node = use_extension("@​rules_nodejs//nodejs:extensions.bzl", "node", dev_dependency = True)
node.toolchain(node_version = "16.14.2")

#################################

npm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "npm", dev_dependency = True)

npm.npm_translate_lock(
    name = "npm",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

use_repo(npm, "npm")

pnpm = use_extension("@​aspect_rules_js//npm:extensions.bzl", "pnpm")

### Allows developers to use the matching pnpm version, for example:
### bazel run -- @​pnpm --dir /home/runner/work/rules_js/rules_js install
use_repo(pnpm, "pnpm")

Using WORKSPACE

Paste this snippet into your WORKSPACE file:

load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "aspect_rules_js",
    sha256 = "6b7e73c35b97615a09281090da3645d9f03b2a09e8caa791377ad9022c88e2e6",
    strip_prefix = "rules_js-2.0.0",
    url = "https://github.com/aspect-build/rules_js/releases/download/v2.0.0/rules_js-v2.0.0.tar.gz",
)

load("@​aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")

rules_js_dependencies()

load("@​aspect_rules_js//js:toolchains.bzl", "DEFAULT_NODE_VERSION", "rules_js_register_toolchains")

rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@​aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")

npm_translate_lock(
    name = "npm",
    npmrc = "//:.npmrc",
    pnpm_lock = "//:pnpm-lock.yaml",
    verify_node_modules_ignored = "//:.bazelignore",
)

load("@​npm//:repositories.bzl", "npm_repositories")

npm_repositories()

What's Changed

New Contributors

Full Changelog: aspect-build/rules_js@v1.42.3...v2.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from avdv as a code owner August 15, 2024 06:48
@renovate renovate bot added the merge-queue merge on green CI label Aug 15, 2024
@renovate renovate bot force-pushed the renovate/aspect_rules_js-2.x branch from cda3134 to 842d4ed Compare August 21, 2024 20:29
@renovate renovate bot force-pushed the renovate/aspect_rules_js-2.x branch from 842d4ed to a63e376 Compare August 21, 2024 22:42
@avdv
Copy link
Member

avdv commented Aug 22, 2024

Seems this requires some migration:

ERROR: Error computing the main repository mapping: at /home/runner/work/rules_haskell/rules_haskell/haskell/asterius/repositories.bzl:15:5: at /home/runner/work/rules_haskell/rules_haskell/haskell/asterius/asterius_dependencies.bzl:3:6: cannot load '@aspect_rules_js//npm:npm_import.bzl': no such file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdv avdv Awaiting requested review from avdv avdv is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge-queue merge on green CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@avdv